KinectToolbox Issue Tracker Rss Feed

Closed Issue: Kinect.Toolkit.Vector2 is not serializable [31042]

Deltakosh — Tue, 19 Jul 2011 07:35:55 GMT

When I'm closing the project, I get the error:

Type 'Kinect.Toolkit.Vector2' in Assembly 'Kinect.Toolkit, Version=1.0.1.0, Culture=neutral, PublicKeyToken=null' is not marked as serializable.

This comes from the method in LearningMachine.cs:

public void Persist(Stream kbStream)
{
BinaryFormatter formatter = new BinaryFormatter();
formatter.Serialize(kbStream, Paths);
}

Since Vector2 is a sealed class, you can't make it serializable. However, Vector2 is a pretty simple class, containing only Length, X, and Y. On the SDK discussion forums, they recommended that we write interfaces for mocks. I think this could also be done for making things like Vector2 serializable.

For example, something like the following:

[code]
using System;
using System.Runtime.Serialization;

namespace Kinect.Toolkit
{
[Serializable()]
public class SerializableVector2 : ISerializable
{
public float X
{
get { return _vector.X; }
set { _vector.X = value; }
}

public float Y
{
get { return _vector.Y; }
set { _vector.Y = value; }
}

public float Length
{
get { return _vector.Length; }
}

public SerializableVector2 (Vector2 vector)
{
this._vector = vector;
}

public SerializableVector2 (SerializationInfo info, StreamingContext context)
{
X = (float)info.GetValue("X", typeof(float));
Y = (float)info.GetValue("Y", typeof(float));
}

public void GetObjectData(SerializationInfo info, StreamingContext context)
{
info.AddValue("X", X);
info.AddValue("Y", Y);
}

private Vector2 _vector;
}
}
[/code]

However, there is a lot of using Vector2 in the code, so I'm not sure the best approach. Change all the references from Vector2 to SerializableVector2? Or just convert at the last moment?
Comments:

Resolved

Commented Issue: Kinect.Toolkit.Vector2 is not serializable [31042]

Deltakosh — Tue, 19 Jul 2011 07:35:40 GMT

Oups :)

Ok, I marked the Vector2 & Vector3 as serializable :)
I also added a custom binder to allow deserialization of xna vector 2 type.

Created Issue: Kinect.Toolkit.Vector2 is not serializable [31042]

tanderson — Tue, 19 Jul 2011 05:56:45 GMT

When I'm closing the project, I get the error:

Type 'Kinect.Toolkit.Vector2' in Assembly 'Kinect.Toolkit, Version=1.0.1.0, Culture=neutral, PublicKeyToken=null' is not marked as serializable.

This comes from the method:

public void Persist(Stream kbStream)
{
BinaryFormatter formatter = new BinaryFormatter();

formatter.Serialize(kbStream, Paths);
}

Since Vector2 is a sealed class, you can't make it serializable. However, Vector2 is a pretty simple class, containing only Length, X, and Y. On the SDK discussion forums, they recommended that we write interfaces for mocks. I think this could also be done for making things like Vector2 serializable.

For example, something like the following:

[code]
using System;
using System.Runtime.Serialization;

namespace Kinect.Toolkit
{
[Serializable()]
public class SerializableVector2 : ISerializable
{
public float X
{
get { return _vector.X; }
set { _vector.X = value; }
}

public float Y
{
get { return _vector.Y; }
set { _vector.Y = value; }
}

public float Length
{
get { return _vector.Length; }
}

public SerializableVector2 (Vector2 vector)
{
this._vector = vector;
}

public SerializableVector2 (SerializationInfo info, StreamingContext context)
{
X = (float)info.GetValue("X", typeof(float));
Y = (float)info.GetValue("Y", typeof(float));
}

public void GetObjectData(SerializationInfo info, StreamingContext context)
{
info.AddValue("X", X);
info.AddValue("Y", Y);
}

private Vector2 _vector;
}
}
[/code]

However, there is a lot of using Vector2 in the code, so I'm not sure the best approach. Change all the references from Vector2 to SerializableVector2? Or just convert at the last moment?